You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Preset temperature requests now update the selected heating or cooling value while preserving the existing value for the other setting. Invalid preset attributes continue to be rejected. This provides consistent behavior when adjusting either side of a preset, preventing the paired temperature from being unintentionally changed during the request.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 97815c4e-5032-4a86-85ad-7cc81f82db86
Commits
Reviewing files that changed from the base of the PR and between 73a99e3 and 9481276.
Files selected for processing: 2
CHANGELOG.md
plugwise/smile.py
No actionable comments were generated in the recent review.
Walkthrough
The preset-temperature write path now handles preset keys in the match statement. It reads only the unchanged, opposite setpoint before assigning the requested value. A comment identifies the subsequent in-memory domain-object update as being for testing an update.
Changes: Preset temperature writes
Layer / File(s)
Summary
Dispatch and update preset setpoints plugwise/smile.py
set_number handles preset keys in its match statement. set_preset_temperature reads only the opposite setpoint before assigning the requested value. A comment identifies the following domain-object update as being for testing an update.
The preset-write refactor has no established actionable defect and is mergeable subject to normal checks.
Pre-merge checks: 4 · 1
Failed checks: 1 inconclusive
Check name
Status
Explanation
Resolution
Title check
The title is generic and does not identify the preset-temperature changes.
Use a specific title, such as "Refactor preset-temperature handling".
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 1 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: f3a67d40-c5e8-46c3-9799-5f3d82cbb6f2
Commits
Reviewing files that changed from the base of the PR and between b044b78 and 73a99e3.
Files selected for processing: 1
plugwise/smile.py
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit